aboot: Fix A/B slot success logic #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is enough just to set the success flag for the current slot instead of touching the retry counter ourselves. The primary bootloader should do that for us if it sees the success flag. Also it appears we never actually wrote the flags to disk in the original commit, so let's do that with attributes_updated variable and the partition_mark_active_slot function.
|
What about this? shall we merge? |
|
imo yes, this A/B logic is currently broken |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is enough just to set the success flag for the current slot instead of touching the retry counter ourselves. The primary bootloader should do that for us if it sees the success flag.
Also it appears we never actually wrote the flags to disk in the original commit, so let's do that with attributes_updated variable and the partition_mark_active_slot function.