Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python build with debug binaries installed #203

Merged
merged 1 commit into from
May 16, 2022

Conversation

IlgarLunin
Copy link
Contributor

Issue happens when you have debug libraries installed to python.

How to reproduce:

  1. Install any python version INCLUDING DEBUG LIBRARIES
  2. Clone tinyspline
  3. Enable CXX and PYTHON targets
  4. Run cmake
  5. Obsereve cmake error: The "optimized" argument must be followed by a library
    qtcreator_Pw1XF61eub

To overcome this, I moved LIBS argument of cmake_parse_arguments to multi_value_keywords instead of one_value_keywords arg.

Resulting target is linked to a proper dll, depending on current configuration:
DependenciesGui_UmfsE9DSGP


Didn't tested this change on other targets, but for python probably makes sense to start using FindPython2 and FindPython3 instead of deprecated FindPythonLibs

@msteinbeck
Copy link
Owner

Hi @IlgarLunin,

thank you very much for this PR. I'll have a look at your changes.

Didn't tested this change on other targets

The CI will show whether your changes break something.

but for python probably makes sense to start using FindPython2 and FindPython3 instead of deprecated FindPythonLibs

I'll have a look at this.

@msteinbeck msteinbeck merged commit 1e299f0 into msteinbeck:master May 16, 2022
@msteinbeck
Copy link
Owner

Looks fine, thanks.

@IlgarLunin
Copy link
Contributor Author

Thanks a lot for quick response 😺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants