Fix python build with debug binaries installed #203
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue happens when you have debug libraries installed to python.
How to reproduce:
CXX
andPYTHON
targetsThe "optimized" argument must be followed by a library
To overcome this, I moved
LIBS
argument ofcmake_parse_arguments
tomulti_value_keywords
instead ofone_value_keywords
arg.Resulting target is linked to a proper dll, depending on current configuration:
![DependenciesGui_UmfsE9DSGP](https://user-images.githubusercontent.com/8058622/168561684-892687f6-62c9-4c0b-b011-363911175f02.png)
Didn't tested this change on other targets, but for python probably makes sense to start using
FindPython2
andFindPython3
instead of deprecatedFindPythonLibs