starship: update to 1.17.1

[ognevny]

see starship/starship#5690 for PR details

[Biswa96]

Should we wait for that upstream merge request?

[ognevny]

Should we wait for that upstream merge request?

maybe, but I don't know their dependency policy

[ognevny]

maybe, but I don't know their dependency policy

merged! we can leave this applied, this should be in a new release soon

[Biswa96]

The clangarm64 build failed again. @jeremyd2019 Would you like to look into the build issue? Or should we revert the update again?

[jeremyd2019]

The neon_intrins.h in C:/Users/Administrator/.cargo/registry/src/index.crates.io-6f17d22bba15001f/libz-ng-sys-1.1.13/src/zlib-ng/arch/arm/neon_intrins.h does not contain the fix from
zlib-ng/zlib-ng@f9228d8. I don't know why that would be, it appears the git submodule reference was updated for that release of the crate. Maybe a mistake was made when making the release (ie, forgetting to git submodule update?).

[ognevny]

The neon_intrins.h in C:/Users/Administrator/.cargo/registry/src/index.crates.io-6f17d22bba15001f/libz-ng-sys-1.1.13/src/zlib-ng/arch/arm/neon_intrins.h does not contain the fix from
zlib-ng/zlib-ng@f9228d8. I don't know why that would be, it appears the git submodule reference was updated for that release of the crate. Maybe a mistake was made when making the release (ie, forgetting to git submodule update?).

the submodule was updated at rust-lang/libz-sys#162

[ognevny]

The neon_intrins.h in C:/Users/Administrator/.cargo/registry/src/index.crates.io-6f17d22bba15001f/libz-ng-sys-1.1.13/src/zlib-ng/arch/arm/neon_intrins.h does not contain the fix from
zlib-ng/zlib-ng@f9228d8. I don't know why that would be, it appears the git submodule reference was updated for that release of the crate. Maybe a mistake was made when making the release (ie, forgetting to git submodule update?).

the submodule was updated at rust-lang/libz-sys#162

maybe patch wasn't applied correctly... I don't know. let's wait until 1.17.2 release
edit: no, this crate has correct version

[ognevny]

the code there

#if defined(_MSC_VER) && (defined(_M_ARM64) || defined(_M_ARM64EC))
/* arm64_neon.h is MSVC specific */
#  include <arm64_neon.h>
#else
#  include <arm_neon.h>
#endif

[jeremyd2019]

Yes, but the code actually downloaded:

# head /c/Users/Administrator/.cargo/registry/src/index.crates.io-6f17d22bba15001f/libz-sys-1.1.13/src/zlib-ng/arch/arm/neon_intrins.h
#ifndef ARM_NEON_INTRINS_H
#define ARM_NEON_INTRINS_H

#ifdef _M_ARM64
#  include <arm64_neon.h>
#else
#  include <arm_neon.h>
#endif

#if defined(ARM_NEON) && !defined(__aarch64__) && !defined(_M_ARM64)

I think this is some sort of issue with how libz-sys 1.1.13 was released, somehow with different code than a fresh (recursive) checkout of the tag would have. @mati865 cargo is pretty much a mystery to me, is that even possible with how it works?

[jeremyd2019]

Contrast with:

$ git clone -b 1.1.13 --recursive https://github.com/rust-lang/libz-sys.git 

$ head libz-sys/src/zlib-ng/arch/arm/neon_intrins.h
#ifndef ARM_NEON_INTRINS_H
#define ARM_NEON_INTRINS_H

#if defined(_MSC_VER) && (defined(_M_ARM64) || defined(_M_ARM64EC))
/* arm64_neon.h is MSVC specific */
#  include <arm64_neon.h>
#else
#  include <arm_neon.h>
#endif