starvation freedom - and use criterion for rbtree benchmarks #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add rebuild on stats environment variables changing
benchmarks were randomly giving large numbers using #![feature(test)] due to the insert tests intentionally leaking memory. the extra overhead came from the harness deciding to run the test 3x as often resulting in either jemalloc hitting some slower paths, or swapping to disk happening
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mem::forgetin the rbtree insertion benchmarks would occasionally cause large spikes in the benchmarks due to the testing harness deciding to run the benchmark 900 times instead of 300. This created a lot pressure on the allocator, resulting in slowness unrelated to swym.criterionallows exclusion of the destructors from the benchmark timings, as well as the batch running destructors.swymnow prevents transactions from starving. This means that all transactions will eventually commit (unless of course there's an infinite loop, deadlock or other user bug).One less footgun when using swym!