Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add format.legend arguments to treemaps for value, density and manual. #32

Merged
merged 1 commit into from
Oct 12, 2016

Conversation

ellisp
Copy link
Collaborator

@ellisp ellisp commented Oct 11, 2016

Key things to consider before accepting this:

  • I've applied it to treemaps of type "value", "density" and "manual". I'm far from sure this is right (either too many or not enough), needs review / thinking.
  • I've called the argument format.legend to make it consistent with position.legend. However, tmap has legend.format. @mtennekes to make a call on the right way to do it.
  • I've made a single addition to the examples, just for the basic example (GNI, in my opinion fits best).
  • I haven't changed the version or anything.
  • anything else I haven't noticed.

@ellisp ellisp mentioned this pull request Oct 11, 2016
@mtennekes mtennekes merged commit 99be863 into mtennekes:master Oct 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants