Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-add CI job to test Cargo.toml rust-version #2413

Merged
merged 3 commits into from
May 29, 2024
Merged

Conversation

Skgland
Copy link
Contributor

@Skgland Skgland commented May 28, 2024

@Skgland
Copy link
Contributor Author

Skgland commented May 28, 2024

Oh, looks like I missed #2403.
Well I will try and see whats wrong with the wasm build, if I can figure it out I will include that fix here, the CI log looks unhelpful.

@Skgland
Copy link
Contributor Author

Skgland commented May 28, 2024

Locally I can successfully compile it under WSL2 running Ubuntu.
Though I saw it use a lot of RAM, around 13.3 GB I believe is the highest I saw, which is probably too much for the CI Runner.

@Skgland
Copy link
Contributor Author

Skgland commented May 28, 2024

Asciinema Recording: https://asciinema.org/a/J6luDBqPiwsnXxWpri3hFECNC

The highest RAM usage appears to be around 11:41 with 15.2 GB Total System usage and 13.6 GB RES / 16.7 GB VIRT Memory usage for the rustc tasks.

@infogulch
Copy link
Contributor

Previous discussion about compilation memory usage: #2139

We could enable swap, there's a GH action that does this: https://github.com/actionhippie/swap-space This sounds like it would be bad for compile times, but considering that memory usage spikes right at the end it could be tolerable.

@Skgland
Copy link
Contributor Author

Skgland commented May 29, 2024

Looks like increasing the swapfile size from the apparently default 4GB to 10GB worked.
And it isn't even the slowest job.

@mthom mthom merged commit 2d18e0d into mthom:master May 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants