Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Term and LeafAnswer serde serialization #2707

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bakaq
Copy link
Contributor

@bakaq bakaq commented Dec 14, 2024

As a lot of things moved around, I thought making a new PR would be easier than rebasing #2493. This also gives us a clean slate to discuss. The old PR was getting a bit too big, and Github is notoriously bad for big threads of discussions in issues/PRs.

This basically gets to the same point that #2493 was, but with a change to rationals following #2505 (comment) (basically now they are serialized as {"rational": {"numerator": ..., "denominator": ...}}), and also without migrating the integration tests. I believe this will still change a bunch so I defer migrating the integration tests (which depend on serialization) to after this gets merged. This also doesn't have the deserialization from #2505.

@jjtolton, if you really want to continue the JSON API route in #2465 you should rebase onto this. I feel maybe just doing C APIs for dealing with Term (and with that wrapping libraries can do JSON themselves in whatever way they want) will be a faster path to merging than waiting to reach consensus on the serialization format here.

Most relevant points in the discussion until now, to recap:

Also, tip when writing JSON on Github: use json5 in codeblocks. It allows things like comments without freaking out. Compare:

// json
{ "a": 1 }
// json5
{ "a": 1 }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant