Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick up tags with / in name #16

Closed
jess-sol opened this issue Apr 26, 2021 · 0 comments · Fixed by #17
Closed

Pick up tags with / in name #16

jess-sol opened this issue Apr 26, 2021 · 0 comments · Fixed by #17
Labels
bug Something isn't working
Milestone

Comments

@jess-sol
Copy link
Contributor

When tags include / in git, dunamai doesn't see them.

Example:

git init
git commit --allow-empty -m 1 # Avoid #14 
git commit --allow-empty -m 2
git tag v1.0.0
git commit --allow-empty -m 3
git tag test/v1.0.0

dunamai from git --debug --pattern '^test/v(?P<base>\d+\.\d+\.\d+)$'
# Pattern '^test/v(?P<base>\d+\.\d+\.\d+)$' did not match any tags from ['v1.0.0']

This is because on init.py#501 has the following:

git for-each-ref "refs/tags/*'

Which in the above case returns:

refs/tags/v1.0.0

If you use (two asterisks):

git for-each-ref "refs/tags/**'

It works as expected

@mtkennerly mtkennerly added the bug Something isn't working label Apr 27, 2021
@mtkennerly mtkennerly added this to the v1.5.5 milestone Apr 27, 2021
jonringer pushed a commit to jonringer/dunamai that referenced this issue Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants