Add support for local sections #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will correctly deal with pep440 version strings of the form X.Y+local
mtkennerly
requested changes
Dec 2, 2020
|
@mtkennerly made those requested changes |
mtkennerly
approved these changes
Dec 3, 2020
| ) -> str: | ||
| """ | ||
| Create a string from the version info. | ||
|
|
||
| :param metadata: Metadata (commit, dirty) is normally included in | ||
| the local version part if post or dev are set. Set this to True to | ||
| the tagged_metadata version part if post or dev are set. Set this to True to |
There was a problem hiding this comment.
Looks like an accidental find/replace 🙃 But I need to fix up the reference to post/dev anyway, so I can take care of it.
|
@mariusvniekerk This is now available in v1.5.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will correctly deal with pep440 version strings of the form X.Y+local. (as per https://www.python.org/dev/peps/pep-0440/#local-version-identifiers)
The plan is to add the additional support into tools that make use of this such as poetry-dynamic-versioning