-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace lib imports by importlib #192
Conversation
I was looking at this too and noticed that Disclaimer: I'm not affiliated with this project so can't facilitate this getting in. |
@tjni Indeed, that may be usefull. I'll have a look into it this week. Concerning the build fail, checking on Internet, seems like Python 3.6 is not available for the latest version of Ubuntu. |
There are some inconsistent behavior with the tests. Sometimes it works, sometimes it does not (it mostly does not). I'm looking into it. For example: https://github.com/Andromelus/hdfs/actions/runs/4223653951/jobs/7333640441 |
@tjni The test framework only supports Python 3, not bellow. Therefore I will keep the tests on python 3.6 and 3.12. |
Well, more news. fastavro does not support Python 3.12... |
Hello @mtth , do you plan to keep maintaining this library ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @Andromelus and apologies for the very belated review. This importlib
change sounds good. A few comments inline.
No problem. Glad to hear back from you. |
e5813a0
to
4cdfb4b
Compare
Changed. Tests passed on my fork. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @Andromelus, looks good.
This is still broken; there is no |
Goal: fix #191
I am using an alternate laptop for this and cannot run the tests. 😞