Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Menu] Fix iPad detection when applying scroll lock #1342

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

mj12albert
Copy link
Member

@mj12albert mj12albert commented Jan 16, 2025

Closes #1309

Safari on iPad reports navigator.platform as 'MacIntel' (instead of 'iPad'), reference: getsentry/sentry-javascript#12127

@mj12albert mj12albert added core Infrastructure work going on behind the scenes bug 🐛 Something doesn't work labels Jan 16, 2025
Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit a939e2f
🔍 Latest deploy log https://app.netlify.com/sites/base-ui/deploys/6788c4aedcb3410008a2dc86
😎 Deploy Preview https://deploy-preview-1342--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mj12albert mj12albert marked this pull request as ready for review January 16, 2025 08:39
@mj12albert mj12albert changed the title [core] Fix iPad detection [Menu] Fix iPad detection when applying scroll lock Jan 16, 2025
@mj12albert mj12albert added component: menu This is the name of the generic UI component, not the React module! and removed core Infrastructure work going on behind the scenes labels Jan 16, 2025
Copy link
Contributor

@atomiks atomiks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works correctly on Simulator with iPad

@mj12albert mj12albert merged commit 140263d into mui:master Jan 17, 2025
27 checks passed
@mj12albert mj12albert deleted the fix/detect-ipad branch January 17, 2025 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: menu This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Menu] Examples in the docs don't open on iPad
2 participants