[useScrollLock] Fix jump with scroll-behavior style
#1343
Merged
+11
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
oliviertassinari
added
the
component: modal
michaldudak
reviewed
Jan 23, 2025
| @@ -52,6 +53,7 @@ function preventScrollStandard(referenceElement?: Element | null) { | |||
| overflowY: html.style.overflowY, | |||
| overflowX: html.style.overflowX, | |||
| }; | |||
| originalHtmlScrollBehavior = html.style.scrollBehavior; | |||
There was a problem hiding this comment.
Why isn't it a part of originalHtmlStyles?
There was a problem hiding this comment.
It has to be assigned after the .scrollTop/Left assignments
michaldudak
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1340