Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Toolbar] Add Toolbar components #1349

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

[Toolbar] Add Toolbar components #1349

wants to merge 8 commits into from

Conversation

mj12albert
Copy link
Member

@mj12albert mj12albert commented Jan 21, 2025 •
edited
Loading

Demo: https://deploy-preview-1349--base-ui.netlify.app/experiments/toolbar

TODO

  • Components: Root, Button, Link, Group, Separator
  • focusableWhenDisabled prop on Button
  • expose the loop prop on Root
  • hotkey prop on Root
  • grid layout with cols prop
  • orientation prop

Component integrations

  • Dialog
  • Menu
  • Menu with submenu
  • Popover
  • Select
  • Toggle/ToggleGroup
  • Tooltip
  • NumberField
  • DirectionProvider
  • Input ?
  • Switch ?

Closes #661

@mj12albert mj12albert added the component: toolbar The React component. label Jan 21, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 21, 2025 •
edited
Loading

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 2901a4d
🔍 Latest deploy log https://app.netlify.com/sites/base-ui/deploys/679765ec005b200008cc8dc4
😎 Deploy Preview https://deploy-preview-1349--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mj12albert mj12albert changed the title feat/toolbar [Toolbar] Add Toolbar components Jan 28, 2025
@mj12albert mj12albert mentioned this pull request Jan 28, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomiks atomiks Awaiting requested review from atomiks atomiks will be requested when the pull request is marked ready for review atomiks is a code owner

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite will be requested when the pull request is marked ready for review colmtuite is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak will be requested when the pull request is marked ready for review michaldudak is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component: toolbar The React component.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Toolbar] Implement Toolbar
1 participant
@mj12albert