[core] Remove legacy dependencies and settings #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: out-of-date
michaldudak
force-pushed
the
remove-unnecessary-packages
branch
from
0caa528 to
eee7431
Compare
github-actions
bot
added
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
michaldudak
commented
Apr 22, 2024
michaldudak
commented
Apr 22, 2024
Comment on lines
+80
to
+85
| // With our case these assumptions are safe, and the | ||
| // resulting behavior is equivalent to spec mode. | ||
| setPublicClassFields: true, | ||
| privateFieldsAsProperties: true, | ||
| objectRestNoSymbols: true, | ||
| setSpreadProperties: true, |
There was a problem hiding this comment.
These are taken from mui/material-ui#37461
I'm not sure if we actually need all of them as the browsers we target support spreading and private fields natively. But including these does no harm.
michaldudak
changed the title
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
michaldudak
force-pushed
the
remove-unnecessary-packages
branch
from
1892df1 to
be719d5
Compare
atomiks
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed legacy Babel plugins (for supporting older browsers) and some unused npm scripts.
Also set TS target to ES2020 to be more in line with the browser targets we aim to support.