[docs] Content: Accordion, Alert Dialog, Checkbox, Checkbox Group hero demos #892
Conversation
Netlify deploy preview |
| @@ -1,6 +1,7 @@ | |||
| # Dialog | |||
|
|
|||
| <Subtitle>A popup that opens on top of the entire page.</Subtitle> | |||
| <meta name="description" content="A high-quality unstyled dialog component for React." /> | |||
There was a problem hiding this comment.
Point of interest @colmtuite: instead of using the Subtitle above, I added a separate <meta> tag for SEO and link descriptions on socials.
Does this approach and the copy feel right?
There was a problem hiding this comment.
"for React" bothers me slightly
"A high-quality, unstyled React dialog component" maybe?
There was a problem hiding this comment.
@vladmoroz Yep, I like the approach and copy.
There was a problem hiding this comment.
Can we use a custom wrapper component over meta? It'll make it staightforward to implement #612 in the future.
There was a problem hiding this comment.
"A high-quality, unstyled React dialog component" maybe?"
Sure
There was a problem hiding this comment.
@michaldudak sure, I added the 170 char limit right away
|
@vladmoroz Love the vibe 💅 I'm not seeing focus(-visible) styles on either Checkbox or CheckboxGroup? |
|
@colmtuite forgot that, thanks. Updated. |
|
The checkboxes in the Tailwind demos look incorrect: |
|
@michaldudak those are old ones though? Has been like this for a while |
|
🤦♂️ I guess it's time for me to call it a day... |
https://deploy-preview-892--base-ui.netlify.app/new/components/accordion