Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Today button work with 'autoOk' flag #1553

Closed
imcharliesparks opened this issue Mar 1, 2020 · 3 comments · Fixed by #1555
Closed

Make Today button work with 'autoOk' flag #1553

imcharliesparks opened this issue Mar 1, 2020 · 3 comments · Fixed by #1555

Comments

@imcharliesparks
Copy link

date pickers again
(sorry for the same meme on two requests)

Is your feature request related to a problem? Please describe.
I've implemented the <DatePicker /> component and have the autoOk flag turned on. I also have the "Today" button enabled. At present, the user has to hit today, then click on the already highlighted date to get autoOk to close the calendar modal.

Describe the solution you'd like
It would be nice if, when autoOk is enabled, and the user hits "Today", it would have the same functionality as clicking a date with the autoOk flag enabled (i.e. closing the modal and setting the date without having to hit the confirm button).

Describe alternatives you've considered
No alternative I can think of that doesn't involve serious digging and custom method handlers

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 1, 2020

What version are you using? Did you try the v4 alpha?


In #1293, I have proposed to make autoOk the default behavior because it seemed to be more common. What do you think?

@dmtrKovalenko
Copy link
Member

@oliviertassinari yes, it looks like a nice idea, I missed that while doing API changes

@imcharliesparks
Copy link
Author

Thank you for taking the time to respond and act on this!

@dmtrKovalenko @oliviertassinari

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants