Restore removing aria-hidden, and not set it false

mui · Oct 4, 2018 · 21abdf8 · 21abdf8
1 parent 860b952
commit 21abdf8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/material-ui/src/Modal/ModalManager.test.js b/packages/material-ui/src/Modal/ModalManager.test.js
@@ -169,7 +169,7 @@ describe('ModalManager', () => {
       modalManager.add(modal3, container2);
       assert.strictEqual(mountNode2.getAttribute('aria-hidden'), 'true');
       modalManager.remove(modal3, container2);
-      assert.strictEqual(mountNode2.getAttribute('aria-hidden'), 'false');
+      assert.strictEqual(mountNode2.getAttribute('aria-hidden'), null);
     });
 
     it('should remove aria-hidden on siblings', () => {
@@ -178,7 +178,7 @@ describe('ModalManager', () => {
       modalManager.add(modal, container2);
       assert.strictEqual(mountNode1.getAttribute('aria-hidden'), 'true');
       modalManager.remove(modal, container2);
-      assert.strictEqual(mountNode1.getAttribute('aria-hidden'), 'false');
+      assert.strictEqual(mountNode1.getAttribute('aria-hidden'), null);
     });
   });
 });
diff --git a/packages/material-ui/src/Modal/manageAriaHidden.js b/packages/material-ui/src/Modal/manageAriaHidden.js
@@ -20,7 +20,7 @@ export function ariaHidden(show, node) {
   if (show) {
     node.setAttribute('aria-hidden', 'true');
   } else {
-    node.setAttribute('aria-hidden', 'false');
+    node.removeAttribute('aria-hidden');
   }
 }