SVG fontSize sets by default to true and ignore width and height for SVG

[palaniichukdmytro]

SVG fontSize sets by default to true and ignore width and height for SVG

• I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Expected use root overrides style when fonwSize are not provided
So I have overrides for MuiSvgIcon

export default theme => ({
    root: {
        width: 18,
        height: 18,
    },
})

Current Behavior

But when I use my icon without fontSize props, it steal overrides the root style:
<Add />

Context

Your Environment

Tech	Version
Material-UI	v1.0.0-beta.33
React	16.2
browser	Chrome 64
etc

[oliviertassinari]

@palaniichukdmytro Would this change solve your issue?

https://github.com/mui-org/material-ui/pull/10348/files#diff-38574c080d4e2eb38c49b86e6588ad98R106

• Remove the fontSize property from the Icon and SvgIcon components in order to make it the default behavior.
  It's already the default behavior of the Icon component. You will still be able to change the size of the icons with the width and height CSS properties. The difference is that they can use the font-size as a shorthand.

  -<SvgIcon style={{ fontSize: 20 }} fontSize />
  +<SvgIcon style={{ fontSize: 20 }} />

[palaniichukdmytro]

@oliviertassinari actually better do not use fontSize as css api, and style as you mention in style.

[oliviertassinari]

@palaniichukdmytro Sorry, I don't understand your point. What do you think we should change and how you would use the component with this change?

[palaniichukdmytro]

As you can see here when I use svg icon itself without fontSize boolean props , it works as expected. But when I wrapped to IconButton the svg inside use fontsize , but I did not provide it
https://codesandbox.io/s/jnwrq7zv0v

[oliviertassinari]

@palaniichukdmytro Thanks. I confirm the plan change will solve your issue. Basically, we will remove the fontSize style to merge it into the root one. The ButtinIcon will apply a font size. Your override will work as expected.