Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website keeps redirecting me to v0 #17637

Closed
2 tasks done
Maxim-Mazurok opened this issue Sep 30, 2019 · 10 comments · Fixed by #20902
Closed
2 tasks done

Website keeps redirecting me to v0 #17637

Maxim-Mazurok opened this issue Sep 30, 2019 · 10 comments · Fixed by #20902
Labels
docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@Maxim-Mazurok
Copy link
Contributor

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

When I visit https://material-ui.com/#/ it redirects me to https://v0.material-ui.com/#/ every time

Expected Behavior 🤔

I don't want to be redirected to the old version.

Steps to Reproduce 🕹

Steps:

  1. Visit https://material-ui.com/#/

Your Environment 🌎

I'm using stable Chrome 77.0.3865.90 (Official Build) (64-bit) on CentOS 7
Cookies for material-ui only have Google Analytics. Opening in Incognito mode results in the same behavior.

@oliviertassinari
Copy link
Member

It seems expected. Only v0 uses this anchor navigation approach.

@Maxim-Mazurok
Copy link
Contributor Author

Well, it's not what I expect, though.
It appears that I've bookmarked it with the anchor back in the days, and now whenever I type material-ui in my chrome address bar - it suggests me to go to this bookmark.
Your answer helped me to understand the problem. So I changed my bookmark and also I had to clear my browsing history to make Chrome forget about the old version and suggest me only the new version, without the anchor.

Still, I think that for the homepage this behavior should be changed because I expect that I'm not the only one who has old version bookmarked.

@eps1lon
Copy link
Member

eps1lon commented Oct 1, 2019

Still, I think that for the homepage this behavior should be changed because I expect that I'm not the only one who has old version bookmarked.

What about the people that intentionally bookmark docs for v0?

@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 1, 2019

What about the people that intentionally bookmark docs for v0?

@eps1lon I think that a bookmark on the v0 subdomain is better.

This redirection was most useful 1 year and a half ago when we first released v1. I won't object if we remove it at this point. However, I don't matter much either way, I don't expect a significant difference.

@Maxim-Mazurok
Copy link
Contributor Author

Still, I think that for the homepage this behavior should be changed because I expect that I'm not the only one who has old version bookmarked.

What about the people that intentionally bookmark docs for v0?

My idea is to remove redirect only from the home page, not from other pages. As it makes sense, indeed, that people might've bookmarked old docs and are still using them.

@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 2, 2019

My proposal, we kill the redirection next year.

https://github.com/mui-org/material-ui/blob/7a5f830b5b5be9554a60f2fa4d03ec969b145dbe/docs/pages/index.js#L103-L106

Traffic going down:
Capture d’écran 2019-10-02 à 14 42 28

But a large part of the traffic uses this redirection logic:
https://www.similarweb.com/en/website/v0.material-ui.com#referrals

@oliviertassinari oliviertassinari added the on hold There is a blocker, we need to wait label Oct 2, 2019
@mbrookes

This comment has been minimized.

@oliviertassinari

This comment has been minimized.

@mbrookes

This comment has been minimized.

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process. and removed on hold There is a blocker, we need to wait labels Jan 9, 2020
@oliviertassinari
Copy link
Member

I believe the timing to kill the redirection is right (fewer users + there is a viable alternative) #17637 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants