Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chart components to mui src code #1864

Closed
jessjohn opened this issue Oct 12, 2015 · 6 comments
Closed

Add chart components to mui src code #1864

jessjohn opened this issue Oct 12, 2015 · 6 comments
Labels
duplicate This issue or pull request already exists

Comments

@jessjohn
Copy link

Here are screenshots of 3 charts I've whipped up so far:

Vertical Bar Chart

screen shot 2015-10-12 at 1 57 45 pm

Horizontal Bar Chart

screen shot 2015-10-12 at 1 57 57 pm

Bullet Chart

screen shot 2015-10-12 at 1 56 57 pm

The charts are made using nvd3 and each chart's theme inherits from the calling component's mui theme. The screenshots are showing the default-light-theme (they look especially nice when wrapped in the <Paper> component!).

I've got a forked branch set up here that you can look at to see the code.

@shaurya947 @hai-cea - I'd love to hear some thoughts and feedback on adding these components to mui src code.

@isilweo
Copy link

isilweo commented Oct 29, 2015

Hey, just my few cents here. I think D3+NVD3 is overkill in size. I'm not sure if nvd3.min.js from their github has already d3.js inside but probably not. nvd3.min.js is 210kb + d3.min.js almost 150kb. This sums to 360kb and this is alot. I would love to use D3 but I will wait until they modularize it - d3/d3#2461

Maybe an alternative for this is to use PathsJS which is small. Of course you may not agree with this but i think size and complete lack of modularity of nvd3 (+d3) doesn't work well with beauty of material-ui modularity.

@oliviertassinari
Copy link
Member

@jessjohn I'm wondering, are these charts related to the material-design specification?

@alitaheri alitaheri added out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) design: material This is about Material Design, please involve a visual or UX designer in the process labels Dec 9, 2015
@alitaheri
Copy link
Member

Unfortunately this library focuses on implementing the Material Design Specs. We don't want to create a library that does many things. As folks in GNU say, make a lot of tiny libs that do one thing good. So we tend to focus our time on that only.

@Krijovnick
Copy link
Contributor

Hi there,

We are glad to announce that we have begun work on DevExtreme React Charts for Material Design using the delightful Material UI library!

Now we are in the process of intensive development and preparation for the release.

Feel free to download your copy and tell us what you think about its current feature set. We’d love to hear about your business use-case scenarios and how you’d like us to improve our Chart’s going forward.

@oliviertassinari
Copy link
Member

@Krijovnick It's exciting, thanks for sharing!

mnajdova pushed a commit to mnajdova/material-ui that referenced this issue Nov 10, 2020
@oliviertassinari oliviertassinari removed the out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) label Jun 14, 2021
@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 14, 2021

Duplicate of mui/mui-x#1408

@oliviertassinari oliviertassinari added duplicate This issue or pull request already exists and removed design: material This is about Material Design, please involve a visual or UX designer in the process labels Jun 14, 2021
@oliviertassinari oliviertassinari marked this as a duplicate of mui/mui-x#1408 Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

5 participants