Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreeItem does not allow conditional child #20154

Closed
2 tasks done
tonyhallett opened this issue Mar 17, 2020 · 2 comments · Fixed by #20238
Closed
2 tasks done

TreeItem does not allow conditional child #20154

tonyhallett opened this issue Mar 17, 2020 · 2 comments · Fixed by #20238
Assignees
Labels
bug 🐛 Something doesn't work component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!

Comments

@tonyhallett
Copy link
Contributor

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

There is an error

Expected Behavior 🤔

No error

Steps to Reproduce 🕹

https://codesandbox.io/s/wonderful-pond-89ohe

Steps:

  1. Load the sandbox - see that there is nothing displayed. There should be an error but strangely it is not showing. If you really want to see it click the refresh

image

image

Context 🔦

I should be able to conditionally render

<TreeItem nodeId="parent" label="parent">
          {props.renderChild && <TreeItem nodeId="parent" label="child" />}
</TreeItem>
@eps1lon eps1lon added the component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! label Mar 17, 2020
@eps1lon
Copy link
Member

eps1lon commented Mar 17, 2020

I thought #19849 fixed this but it seems to only fix TreeView not TreeItem.

@eps1lon eps1lon added the bug 🐛 Something doesn't work label Mar 17, 2020
@tonyhallett
Copy link
Contributor Author

#20156

There are more serious bugs than this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants