[TreeItem] allow conditional child #20154 #20156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tonyhallett
commented
Mar 17, 2020
tonyhallett
commented
- I have followed (at least) the PR section of the contributing guide.
2 tasks
eps1lon
reviewed
Mar 17, 2020
| </TreeItem> | ||
| </TreeView>, | ||
| ), | ||
| ).to.not.throw(); |
There was a problem hiding this comment.
It would be awesome if you could be more specific about the expected output. For example should nodeId="1" be considered expanded or is it a leaf node?
There was a problem hiding this comment.
@tonyhallett Did you accidentally resolve this comment? Not sure how this was addressed.
There was a problem hiding this comment.
Have mirrored the test in the TreeView. Apologies for the addiitonal prettier commit
eps1lon
added
component: tree view
Details of bundle changes.Comparing: 7e1da61...854c0fd Details of page changes
|
eps1lon
reviewed
Mar 17, 2020
| ); | ||
| } | ||
| const { getByText, queryByText } = render(<TestComponent />); | ||
| expect(getByText('test')).to.not.be.null; |
There was a problem hiding this comment.
Please don't use getByText. It's extremely brittle. You can leverage ByTestId since you already added testids.
Also: what is the expected aria-expanded before and after the click?
There was a problem hiding this comment.
Ok, as I said I mirrored the existing TreeView test. There are many getByText.
Will update
There was a problem hiding this comment.
Ok, as I said I mirrored the existing TreeView test. There are many getByText.
No worries. Sometimes these slip by.
|
@eps1lon pls can you advise on the failure. |
github-actions
bot
added
the
PR: out-of-date
1 task
|
@tonyhallett Flaky netlify deploy. You need to rebase anyway so this should resolve itself. |
|
Going to be easier to just do the change again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.