Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card issues/features #2391

Closed
genyded opened this issue Dec 6, 2015 · 9 comments
Closed

Card issues/features #2391

genyded opened this issue Dec 6, 2015 · 9 comments
Labels
new feature New feature or request

Comments

@genyded
Copy link

genyded commented Dec 6, 2015

Would it be possible to enhance Cards per the following?:

  1. Make Avatar in the Header optional - I tried setting it to null, but the default circle still shows up

  2. Make it so that ONLY clicking the expandableButton expands the card (this will likely mean if this is set TURE then showing the button must also be set TRUE). Right now click ANYTHING in the header expands and contracts which limits what can be done with the elements in the header.

I have a set of Cards where clicking a button in the Header adds an item to the content/body of the Card. The issue with having them expand and contract when clicking 'anywhere' in the header is that when the button is clicked the card opens and closes which is not wanted. I also have click to edit titles on some cards and this also causes them to expand and contract.

I can sort of work around this by adding a non-expandable element below the header and putting the button there, but that makes the cards larger and does not really look as nice. In the image below, the titles next to the Avatars (which I don't even want displayed) are editable in click and the button below them adds a row to the body od the card.

image

@alitaheri
Copy link
Member

This would rather be trivial. and what you ask is valid. If you need this ASAP you are welcome to make a PR, otherwise, we'll have to sort some other things before making this enhancement.

@genyded
Copy link
Author

genyded commented Dec 6, 2015

I am just prototyping for now and can work around it. But it would be nice once some of the larger fires are out. Thanks!

@oliviertassinari
Copy link
Member

  1. Looks like we have a first attent here [CardHeader] Make avatar prop optional  #1879

@alitaheri
Copy link
Member

@oliviertassinari I'll continue that PR too.

@alitaheri
Copy link
Member

  1. fixed.

@genyded
Copy link
Author

genyded commented Dec 6, 2015

Awesome gentlemen! I think #2 will be tricky, but hopefully soon and if so REALLY looking forward to the next release. We're making VERY extensive use of Cards and in fact most of you components.

@alitaheri alitaheri added new feature New feature or request and removed Enhancement labels Dec 8, 2015
@alitaheri alitaheri modified the milestone: 0.14.0 Release Dec 9, 2015
@alitaheri
Copy link
Member

@genyded seems like actAsExpander was there all along -_- The name needs revision. if you set it to true on your CardHeader then only the expand icon can expand it. See if that fixes it.

@genyded
Copy link
Author

genyded commented Dec 14, 2015

Ahhh. so that's what that does... but actually it looks like setting it to false makes it so only the icon expands... true anywhere in the header expandss. Thanks!

@genyded genyded closed this as completed Dec 14, 2015
@alitaheri
Copy link
Member

Ahhh. so that's what that does

Exactly my reaction :D It's very confusing, and I cannot come up with any names! I'm gonna open an issue for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants