Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CardHeader] Rename actAsExpander #2512

Closed
alitaheri opened this issue Dec 14, 2015 · 1 comment
Closed

[CardHeader] Rename actAsExpander #2512

alitaheri opened this issue Dec 14, 2015 · 1 comment
Labels
component: card This is the name of the generic UI component, not the React module! discussion

Comments

@alitaheri
Copy link
Member

After the discussion in #2391, I believe the name actAsExpander is very confusing. Yet I do not know what to change it to.

Just to clarify, setting actAsExpander to true changes the CardHeader so that clicking everywhere will expand the Card. While setting it to false forces expansion only through the icon on the right.

@oliviertassinari oliviertassinari added the component: card This is the name of the generic UI component, not the React module! label Dec 18, 2016
@oliviertassinari
Copy link
Member

The actAsExpander property was removed on the next branch. Nathan have turned that feature inside-out. We are now exposing a Collapse component to implement it. It's much better.
For instance:

<Collapse in={this.state.expanded} transitionDuration="auto" unmountOnExit>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: card This is the name of the generic UI component, not the React module! discussion
Projects
None yet
Development

No branches or pull requests

2 participants