Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icons] Add TikTok icon #35100

Open
M-Fasciano opened this issue Nov 11, 2022 · 9 comments
Open

[icons] Add TikTok icon #35100

M-Fasciano opened this issue Nov 11, 2022 · 9 comments
Labels
new feature New feature or request package: icons Specific to @mui/icons waiting for 👍 Waiting for upvotes

Comments

@M-Fasciano
Copy link

M-Fasciano commented Nov 11, 2022

Summary 💡

Is it possible to add the TikTok icon?

Examples 🌈

No response

Motivation 🔦

No response

@M-Fasciano M-Fasciano added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Nov 11, 2022
@zannager zannager added the package: icons Specific to @mui/icons label Nov 11, 2022
@M-Fasciano M-Fasciano changed the title Tiktok icon TikTok icon Nov 11, 2022
@siriwatknp siriwatknp added new feature New feature or request waiting for 👍 Waiting for upvotes and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Nov 21, 2022
@Vivek-Prajapatii

This comment was marked as outdated.

@siriwatknp
Copy link
Member

This is all the brands we have, I guess we could have TikTok icon as well given its popularity. cc @oliviertassinari @mui/core

Screen Shot 2566-01-24 at 11 29 17

@michaldudak
Copy link
Member

michaldudak commented Jan 26, 2023

We generally don't accept new icons (see #19371). This package is meant to mirror what's available in Material Design Icons.

@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 27, 2023

TikTok has 1 billion users, I think that with more upvotes on this issue, we could add it, as a convenient helper.

@michaldudak
Copy link
Member

michaldudak commented Jan 27, 2023

Discord supposedly has over 140 million active monthly users and 300 million registered accounts (source: https://www.businessofapps.com/data/discord-statistics), and we rejected its icon. Where do we draw the line?

I'd consider removing all the brand icons in v6 and leaving only the Material Design ones, so we don't need to decide arbitrarily what goes in. If we ever create our own set of icons, we can include the brands there.

@samuelsycamore
Copy link
Contributor

Discord supposedly has over 140 million active monthly users and 300 million registered accounts (source: https://www.businessofapps.com/data/discord-statistics), and we rejected its icon. Where do we draw the line?

+1 for establishing where we draw the line 😁

I'd consider removing all the brand icons in v6 and leaving only the Material Design ones, so we don't need to decide arbitrarily what goes in. If we ever create our own set of icons, we can include the brands there.

Social icons are such a common use case for icon packs, though. I feel like we would be annoying a lot of users by not including them. And I think we would prefer that users not have to leave our ecosystem to get the icons they need.

@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 29, 2023

and we rejected its icon. Where do we draw the line?

@michaldudak I think that it's a matter of the frequency people add them to their page. The best proxies I'm aware of

  1. the search pattern: https://www.notion.so/mui-org/Product-Analytics-f2e2576203564e6c8dc3429cf305a36f#438ef85b318a4d3d89cb18813c0565ed
  2. upvotes on GitHub issues.
  3. the popularity of the platform.

But maybe the rule of thumb is, can you see it often in these footers?

Screenshot 2023-01-29 at 22 20 32

Screenshot 2023-01-29 at 22 20 16

If yes, add it.

to leave our ecosystem to get the icons they need.

@samuelsycamore We could add docs about how to use https://mui.com/material-ui/icons/#svgicon with https://simpleicons.org/.

@oliviertassinari oliviertassinari changed the title TikTok icon [icons] Add TikTok icon Dec 2, 2023
@stephen-barrow
Copy link

so are you going to add it or will have to leave the ecosystem just for one icon

@FarzinKhaledi
Copy link

this is how you add TikTok mui icon to nextjs 15 typescript

import SvgIcon from "@mui/material/SvgIcon";

// Custom TikTok icon component
const TikTokIcon = (props: any) => (
<SvgIcon {...props} viewBox="0 0 48 48">


);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request package: icons Specific to @mui/icons waiting for 👍 Waiting for upvotes
Projects
None yet
Development

No branches or pull requests

9 participants