-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[icons] Add TikTok icon #35100
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This is all the brands we have, I guess we could have TikTok icon as well given its popularity. cc @oliviertassinari @mui/core |
We generally don't accept new icons (see #19371). This package is meant to mirror what's available in Material Design Icons. |
TikTok has 1 billion users, I think that with more upvotes on this issue, we could add it, as a convenient helper. |
Discord supposedly has over 140 million active monthly users and 300 million registered accounts (source: https://www.businessofapps.com/data/discord-statistics), and we rejected its icon. Where do we draw the line? I'd consider removing all the brand icons in v6 and leaving only the Material Design ones, so we don't need to decide arbitrarily what goes in. If we ever create our own set of icons, we can include the brands there. |
+1 for establishing where we draw the line 😁
Social icons are such a common use case for icon packs, though. I feel like we would be annoying a lot of users by not including them. And I think we would prefer that users not have to leave our ecosystem to get the icons they need. |
@michaldudak I think that it's a matter of the frequency people add them to their page. The best proxies I'm aware of
But maybe the rule of thumb is, can you see it often in these footers? If yes, add it.
@samuelsycamore We could add docs about how to use https://mui.com/material-ui/icons/#svgicon with https://simpleicons.org/. |
so are you going to add it or will have to leave the ecosystem just for one icon |
this is how you add TikTok mui icon to nextjs 15 typescript import SvgIcon from "@mui/material/SvgIcon"; // Custom TikTok icon component |
Summary 💡
Is it possible to add the TikTok icon?
Examples 🌈
No response
Motivation 🔦
No response
The text was updated successfully, but these errors were encountered: