[website] Link Discord in footer #38369
Conversation
richbustos
requested review from
joserodolfofreitas,
oliviertassinari,
danilo-leal and
samuelsycamore
richbustos
added
the
website
docs/src/icons/SvgDiscord.tsx
Outdated
| @@ -0,0 +1,19 @@ | |||
| import * as React from 'react'; | |||
| import RootSvg, { RootSvgProps } from 'docs/src/icons/RootSvg'; | |||
There was a problem hiding this comment.
I think it should use SvgIcon here.
There was a problem hiding this comment.
I'm having issues using SvgIcon. I don't think it's properly set up in /layout folder path because every time I import SvgIcon, I get a weird error for the fontSize prop. I even tried overriding the default prop but still got an error. I also so don't see any use-cases of SvgIcon in the /layout folder, which makes me believe that the person who implemented the StackOverflow icon on the footer had the same issue as me. Im using the same convention as SvgStackOverflow in docs/src/icons/SvgStackOverflow.
The proper way this should be handled is by adding these icons in our official Material UI Icons, but saw that it is currently not in our scope:
The Discord blog and Tweet will be going out this week and would like the footer to be ready by then. I can address the Material UI Icon and/or the SvgIcon issue after if that's okay.
There was a problem hiding this comment.
I pushed a change with what I had in mind with my comment. It's more using Material UI "by the book".
Co-authored-by: Olivier Tassinari <[email protected]> Signed-off-by: Rich Bustos <[email protected]>
Netlify deploy previewhttps://deploy-preview-38369--material-ui.netlify.app/ Bundle size report |
oliviertassinari
changed the title
We created a blog for the Discord announcement. Now adding Discord icon on the footer with all the other social media platforms.
Will soon add to the support page.
https://deploy-preview-38369--material-ui.netlify.app/