Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datepicker] Current date doesn't update #3545

Closed
mbrookes opened this issue Mar 1, 2016 · 3 comments
Closed

[Datepicker] Current date doesn't update #3545

mbrookes opened this issue Mar 1, 2016 · 3 comments
Labels
component: date picker This is the name of the generic UI component, not the React module! component: pickers This is the name of the generic UI component, not the React module!

Comments

@mbrookes
Copy link
Member

mbrookes commented Mar 1, 2016

Problem Description

If a page using DatePicker is opened on one date, and the Date Picker on that page is opened on another (i.e. after midnight), the default date / current date are for the previous day.

@nathanmarks pinpointed this to the date being set in GetInitialState, so not changing until a page refresh.

Versions
@tintin1343
Copy link
Contributor

@mbrookes : I was looking at this issue yesterday.

@nathanmarks pinpointed this to the date being set in GetInitialState, so not changing until a page refresh.

I observed the same thing.

Shall I proceed with working on this?

@mbrookes
Copy link
Member Author

mbrookes commented Mar 9, 2016

Great!

@tintin1343 tintin1343 mentioned this issue Mar 10, 2016
Merged
3 tasks
tintin1343 added a commit to tintin1343/material-ui that referenced this issue Mar 10, 2016
@tintin1343
[Datepicker] Add a check to fetch current system date
6d8a952 
Added a check which helps pick the current system date when the date-picker dialog
 is opened.

Resolves mui#3545
@tintin1343
Copy link
Contributor

@mbrookes : Fixed.

tintin1343 added a commit to tintin1343/material-ui that referenced this issue Mar 10, 2016
@tintin1343
[Datepicker] Add a check to fetch current system date
d7292a0 
Added a check which helps pick the current system date when the date-picker dialog
 is opened.

Resolves mui#3545
tintin1343 added a commit to tintin1343/material-ui that referenced this issue Mar 11, 2016
@tintin1343
[Datepicker] Add a check to fetch current system date
5847f99 
Added a check which helps pick the current system date when the date-picker dialog
 is opened.

Resolves mui#3545
aahan96 pushed a commit to aahan96/material-ui that referenced this issue Mar 17, 2016
@tintin1343 @aahan96
[Datepicker] Add a check to fetch current system date
dbacfba 
Added a check which helps pick the current system date when the date-picker dialog
 is opened.

Resolves mui#3545
und3fined pushed a commit to und3fined/material-ui that referenced this issue Mar 22, 2016
@tintin1343
[Datepicker] Add a check to fetch current system date
426e807 
Added a check which helps pick the current system date when the date-picker dialog
 is opened.

Resolves mui#3545
@zannager zannager added component: date picker This is the name of the generic UI component, not the React module! component: pickers This is the name of the generic UI component, not the React module! labels Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: date picker This is the name of the generic UI component, not the React module! component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mbrookes @tintin1343 @zannager