-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialogue component doesn't size to width specified by user #3675
Comments
Thanks for the reply. Is there a reason for the dialog having such specific functionality? Do you think it would make more sense to have width refer to dialog's inner panel and have the more specifically named width prop for the outer part? |
@niole It was like that once, I added that prop and then we saw the complexity it would introduce so we deprecated it and added an example to demonstrate how it should be done. the complexity comes from |
Speaking of overcomplication, I have also been experimenting with the
|
@niole No all our components are slow right now. Because they have heavy render functions and they don't implement |
No kidding. My first instinct would be to use |
@niole |
This has been really informative! Closing ... |
Problem Description
When I specify a width for the Dialogue component, it doesn't size to the width I want, but 75% percent of that. Also, if I specify a width, the component does not center itself accordingly. I am specifying the width via the style attribute e.g.:
I realize that this style attribute corresponds more to the width of
window
.As the background behind the modal always grays out the entire screen and not only the user specified width, it doesn't make sense for the style props's width key to correspond to the width of the window.
I find this unintuitive and think the usability of this component could be revised so that it corresponds more to how a user would approach it's customization.
I would include a screen shot, but I'm working under NDA.
Versions
The text was updated successfully, but these errors were encountered: