Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoComplete] controlled searchText #6618

Closed
NickMalt opened this issue Apr 16, 2017 · 8 comments · Fixed by #6621
Closed

[AutoComplete] controlled searchText #6618

NickMalt opened this issue Apr 16, 2017 · 8 comments · Fixed by #6621
Labels
bug 🐛 Something doesn't work component: autocomplete This is the name of the generic UI component, not the React module!

Comments

@NickMalt
Copy link

Description

There is undesirable behaviour in cases when we conrol searchText by ourselves: input filled with selected value for a moment.
You can reproduce it here docs(Controlled Example), by selecting value from menu.
apr-16-2017 19-58-38

Versions

  • Material-UI: 0.17.4
  • React: 15.4.2
  • Browser: any
@oliviertassinari
Copy link
Member

Well, the example you are showing is the expected behavior I wanted to implement.
I agree that we could want to filter out the Red value in the text field. Unfortunately we can't apply a if (options.source !== 'touchTap') { logic as the AutoComplete keeps an internal searchText state even when the component is controlled. It would be good to remove it 👍 .

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work and removed Regression labels Apr 16, 2017
NickMalt pushed a commit to NickMalt/material-ui that referenced this issue Apr 18, 2017
oliviertassinari pushed a commit that referenced this issue Apr 19, 2017
@caiorg
Copy link

caiorg commented Apr 20, 2017

Hey @oliviertassinari, are there any plans for releasing a version with this fix?

It would be extremely helpful as I'm on 0.17.4 still facing this issue.

@oliviertassinari
Copy link
Member

We try to release every two weeks. Might have to wait a bit to get it on npm.

@caiorg
Copy link

caiorg commented Apr 21, 2017 via email

@vladimirivanoviliev
Copy link

As this behavior is still reproducible in the latest version (v0.20) - will the fix eventually be included or we should wait for v.1 to fix it?

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 20, 2018

@vladimirivanoviliev No updates are planned for v0.20, we have had almost no activity over the last 90 days on the v0.x branch. This issue should already be resolved on v1-beta.

@vladimirivanoviliev
Copy link

When approximately the v.1 is expected to get out of beta? Thanks

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 20, 2018

@vladimirivanoviliev Most likely during react europe conference. The v1-beta is only in beta because we plan breaking changes, from a implementation quality perspective, it has been stable for 1 year+.

@oliviertassinari oliviertassinari added the component: autocomplete This is the name of the generic UI component, not the React module! label Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: autocomplete This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants