[List] Fix w3c issues #10050
Merged
[List] Fix w3c issues #10050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
oliviertassinari
force-pushed
the
w3c-list
branch
from
e15a586 to
335d4d6
Compare
oliviertassinari
force-pushed
the
w3c-list
branch
2 times, most recently
from
1b64909 to
6570fde
Compare
oliviertassinari
force-pushed
the
w3c-list
branch
from
6570fde to
7998fc6
Compare
mbrookes
previously requested changes
Jan 27, 2018
| @@ -8,8 +8,14 @@ components: Divider | |||
|
|
|||
| ## List Dividers | |||
|
|
|||
| The divider renders as a `<hr>` by default. | |||
| You can save this DOM element by using the `divider` property on the `ListItem` component. | |||
There was a problem hiding this comment.
"save rendering this DOM element"
There was a problem hiding this comment.
You could perhaps add an example of that to the List demos (or revise an existing one), and link to it from here.
| {{"demo": "pages/demos/dividers/ListDividers.js"}} | ||
|
|
||
| ## Inset Dividers | ||
|
|
||
| The following example demonstrates the `inset` property. | ||
| We need to make sure the `Divider` is rendered as a `li` to match the HTML5 specification. |
There was a problem hiding this comment.
Perhaps add: "The example shows two ways of achieving this."
src/ButtonBase/ButtonBase.js
Outdated
| // Don't automatically add the role="button" property on these components. | ||
| // It's invalid HTML syntax. | ||
| const INVALID_COMPONENT_ROLE = ['a']; | ||
|
|
||
| /** | ||
| * `ButtonBase` contains as few styles as possible. | ||
| * It aims to be a building block for people who want to create a simple button. |
There was a problem hiding this comment.
"It aims to be a building block for creating a simple button."
oliviertassinari
force-pushed
the
w3c-list
branch
from
7998fc6 to
3e853b3
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have fixed a lot of errors 🎉 :
Error: Element “hr” not allowed as child of element “ul” in this context.
Reason: hr is used as a direct chid of ul (I am not 100% sure if this is in component source or demo/docs only)
Error: Bad value “button” for attribute “role” on element “li”
Reason: May be demo error only.
It's tricky to get this right. it's related to #9867