Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Select] Ensure label is shrinked when using startAdornment #10474

Merged
merged 2 commits into from
Feb 28, 2018
Merged

[Select] Ensure label is shrinked when using startAdornment #10474

merged 2 commits into from
Feb 28, 2018

Conversation

carab
Copy link
Contributor

@carab carab commented Feb 28, 2018

Resolves #10473

@oliviertassinari oliviertassinari added new feature New feature or request component: select This is the name of the generic UI component, not the React module! labels Feb 28, 2018
@oliviertassinari oliviertassinari changed the title [TextField] Ensure label is shrinked when using startAdornment with S… [Select] Ensure label is shrinked when using startAdornment Feb 28, 2018
@oliviertassinari oliviertassinari merged commit 6f7bba1 into mui:v1-beta Feb 28, 2018
@oliviertassinari
Copy link
Member

@carab It's a great first time pull request 👌 . Thanks!

@carab
Copy link
Contributor Author

carab commented Feb 28, 2018

Thanks ! More may come in the future :p

@oliviertassinari
Copy link
Member

I would love to review more in the future :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: select This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carab @oliviertassinari