[core] Add a components property #11198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well no. It's a mess. I'm breaking it into different pull-requests. It was great for the reflection and gluing everything together though :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
classes.menuItemcustomization point to mess around. We can potentially addcomponents.MenuItemin the future.xxxPropsproperties as they are quite handy for simple configuration. We introduce acomponents?: Objectproperty that can be used for all sort of customization. It's underused right now. But It should allow us to grow in the future stable releases. Also, it's providing some symetry with theclassesproperty. Hopefully, it's simpler to understand this way.I couldn't find a clean way to support the render prop pattern :/. Let's try again in the future. This shouldn't require breaking changes.
Breaking change