-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CircularProgress] Remove min & max props #11211
[CircularProgress] Remove min & max props #11211
Conversation
Makes the API consistant with LinearProgress
@mbrookes Should we add a note about accessibility and document the upgrade path after this breaking change? |
The upgrade path should be obvious to anyone capable of using the component, but sure, we can cover it in the release notes. Not sure I understand on the accessibility question - it's already taken care of. (You don't need to specify |
@mbrookes I was wondering if adding a demo demonstrating the min/max use case + the accessibility correctly taken care of would be valuable. |
I can add a demo for min / max if you really think it's needed, but there's isn't anything to demo for ARIA. |
I see some value in it. I don't think it's really needed. |
I've added a quick demo by modifying the current CircularDeterminate demo. Let me know if you think it should be a separate demo (rather than complicate the basic one), or whether a note in the docs with the sample code: const normalise = value => (value - MIN) * (MAX - MIN); would be sufficient. |
Oh, it's even better! It sounds like the best of the two worlds :) |
@mbrookes You forgot to change the typescript definition :-D I'm on it now. |
Thanks - I don’t use TS so always forget it. |
I think there was a typo or something in the example of a normalize-function in the docs. I've added a PR to fix it: #12066 . |
Makes the API consistant with LinearProgress
Breaking change