Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[typescript] Add CreateMuiTheme props Typescript definition #11296

Merged
merged 2 commits into from
May 10, 2018
Merged

[typescript] Add CreateMuiTheme props Typescript definition #11296

merged 2 commits into from
May 10, 2018

Conversation

abnersajr
Copy link
Contributor

@abnersajr abnersajr commented May 9, 2018 •
edited by oliviertassinari
Loading

In the PR #10671, it has been added a new approach to passing props to edit components behavior, using the createMuiTheme function, although TypeScript definitions weren't added.

Closes #11278

@oliviertassinari oliviertassinari requested a review from pelotom May 9, 2018 18:42
@oliviertassinari oliviertassinari changed the title [TypeScript] Add CreateMuiTheme props Typescript definition [typescript] Add CreateMuiTheme props Typescript definition May 9, 2018
@oliviertassinari oliviertassinari added the new feature New feature or request label May 9, 2018
pelotom
pelotom suggested changes May 9, 2018
View reviewed changes
Copy link
Member

@pelotom pelotom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Could you add some typings tests for this to styles.spec.tsx?

@abnersajr
Copy link
Contributor Author

I will check that @pelotom ASAP.

@abnersajr
Copy link
Contributor Author

abnersajr commented May 10, 2018 •
edited
Loading

@pelotom I added some props. I hope I have understood what was desired.
I'm using Visual Studio Code 1.2.3 on Ubuntu 18.04 LTS.
Node 8.9.4 in my environment and Typescript 2.8.4.
Everything looks great, the types are working like a charm.

pelotom
pelotom approved these changes May 10, 2018
View reviewed changes
Copy link
Member

@pelotom pelotom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@pelotom pelotom merged commit f64c730 into mui:v1-beta May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@pelotom pelotom pelotom approved these changes

Assignees
No one assigned
Labels
new feature New feature or request typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abnersajr @pelotom @oliviertassinari