[typescript] Fix keyof for [email protected]

[mctep]

Fixes #11656

[pelotom]

Why not just redefine Omit to allow using any valid key type?

export type Omit<T, K extends keyof any> = Pick<T, Exclude<keyof T, K>>;

[mctep]

Yes. It is better. Thank you! 👍

[pelotom]

Thanks!

[activebiz]

I am still having the same issue in "@material-ui/core": "1.2.0","@material-ui/icons": "1.1.0",. Not sure if I am not pulling right version?

[mctep]

@activebiz Thats right. Could you also provide your TS version, tsconfig.json and error message?

[activebiz]

@mctep thanks
TS is 2.9.1
I get this same issue:
#11671

If I revert the TS to 2.8.4 I get following:

` node_modules/@material-ui/core/ButtonBase/ButtonBase.d.ts
(11,38): Namespace 'React' has no exported member 'RefObject'.

node_modules/@material-ui/core/styles/withStyles.d.ts (51,37): Namespace 'React' has no exported member 'RefObject'.

Thanks

[mctep]

@activebiz Looks like that it is not the same issues. Which versions of @types/react and @types/react-dom do you use? Try to update it to the latest.

[Ritorna]

Same as in issue #11671 here.
Using TypeScript 2.9.1, React 16.4. @types/react 16.3.16 and @Material-ui/core 1.2.0

[activebiz]

@mctep exactly what @Ritorna said

Typescript 2.9.1
React 16.4
React Typescript def: 16.3.16
Material ui core typescript def: 1.2.0

[Ritorna]

@mctep, @activebiz see issue #11698
Worked for me there, just set "allowSyntheticDefaultImports": false in your config, or use the latest Typescript build.

[activebiz]

thanks @Ritorna. Now those errors are gone but got hundreds of new errors. Looks like something wrong with my tsconfig. would you mind sharing your tsconfig ?

Here's mine

{
  "compilerOptions": {
     ...
    "experimentalDecorators": true,
    "allowSyntheticDefaultImports": false,
    "sourceMap": true,
    "moduleResolution": "node",
    "strictNullChecks": true,
    "noUnusedLocals": true,
    "noUnusedParameters": true,
    "types": [
      "react-dom",
      "react",
      "node"
    ],
    "lib": ["es2015", "es2017", "dom"]
  },
...
}

[Ritorna]

@activebiz i guess it mainly depends on which modules you import :/

Here you are:
https://gist.github.com/Ritorna/56885575b7241688af6aca7375302e18.js

Please see this:

Alternatively you may use typescript@next preview, this also fixed it for me

[activebiz]

For me following fixed all the d.ts erros.

[michael-land]

Looks like it cannot correctly infer type def when export component with compose helper.

// Example.tsx
const Example: React.SFC<WithStyles<typeof styles>> = (props) => {
  const { classes } = props;

  return <div className={classes.root}>Material-UI</div>;
};

const styles = ({  }: Theme) =>
  createStyles({
    root: {},
  });

export default compose(
  withStyles(styles),
  withTheme()
)(Example);

// Usage.jsx
import React from 'react';

import Example from './Example';
const Usage: React.SFC = () => <Example />;   // [ts] JSX element type 'Example' does not have any construct or call signatures.

It will works if you just export default withTheme()(withStyles(styles)(Example));

It also doesn't work with other HOC such as redux connect() utility.