[docs] Add Emotion to style interoperability guide #12966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrookes
previously requested changes
Sep 22, 2018
| export default ReactEmotionButton; | ||
| ``` | ||
|
|
||
| [](https://codesandbox.io/s/nkx4p8rw9l) |
There was a problem hiding this comment.
Also, should I change the titles of the sandbox demos to be more consistent with other examples?
-Material UI - React Emotion Button
+React Emotion Button
lukePeavey
commented
Sep 23, 2018
| @@ -277,7 +274,7 @@ const StyledButton = styled(Button)` | |||
| color: white; | |||
| height: 48px; | |||
| padding: 0 30px; | |||
| box-shadow: 0 3px 5px 2px rgba(255, 105, 135, 0.3); | |||
| box-shadow: 0 3px 5px 2 px rgba(255, 105, 135, 0.3); | |||
There was a problem hiding this comment.
I'll fix this one too.
mbrookes
approved these changes
Sep 23, 2018
|
@lukePeavey thanks! Just holding for @oliviertassinari 's review. |
|
@lukePeavey Good job! I will keep an eye on the usage count of Codesandbox to sort the demos. |
|
Sounds good! |
marcelpanse
pushed a commit
to marcelpanse/material-ui
that referenced
this pull request
Oct 2, 2018
* [docs] Add Emotion to style interoperability guide * Add note on controlling priority to React Emotion section * Remove extra spaces * let's merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12054
I added an additional Emotion example to demonstrate overriding styles with
classesprop.Just let me know if there is anything you want me to change
Here are the links to demos, if you want to fork to them your account I'll update the links.
Emotion - Overriding styles with classes prop
React Emotion