Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SpeedDial] Improve hover intent between Dial and Actions #13018

Merged
merged 3 commits into from
Oct 2, 2018
Merged

[SpeedDial] Improve hover intent between Dial and Actions #13018

merged 3 commits into from
Oct 2, 2018

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Sep 27, 2018 •
edited
Loading

Includes

  1. fix inconsistent spacing between Dial and Actions across directions which also cause alignment issues
  2. hovering from Dial to Actions is now more forgiving
  3. Add direction switches to simple SpeedDial example

To 1. (a033718)

Before

speeddial-alignment-before

After

speeddial-alignment-after

To 2. (efd6d95)

Before

speeddial-hover-before

After

speeddial-hover-after

@oliviertassinari oliviertassinari added the component: speed dial This is the name of the generic UI component, not the React module! label Sep 27, 2018
@eps1lon
Copy link
Member Author

eps1lon commented Oct 2, 2018

@oliviertassinari I don't know how to tell argos that this is fine. Until then merging is blocked.

@eps1lon eps1lon merged commit e30c2ac into mui:master Oct 2, 2018
@eps1lon eps1lon deleted the fix/speeddial/hover-exit branch October 2, 2018 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: speed dial This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eps1lon @oliviertassinari