[Select] Document the filled and outlined variants #13071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
oliviertassinari
changed the title
oliviertassinari
added
docs
oliviertassinari
force-pushed
the
feature/Doc-Select-Outlined-Filled
branch
from
0cfefb6 to
3708358
Compare
|
Right, making the select outlined and filled work is a bit more work than with the TextField. We are supporting code splitting, each input variant has to be imported. |
|
@JulienUsson Merci :) |
|
So, Select does not currently support variant="outlined" ? |
|
You can see it live in https://material-ui.netlify.com/demos/selects/#simple-select. |
|
Perfect, thank you so much! |
|
Hello, docs currently suggest that Select variant handles 'standard' | 'outlined' | 'filled' however implementation in demo is achieved by passing OutlinedInput via input props. Is there plans to have this entirely configurable via variant prop? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I update the demos in the select page like you said in #13049
but i think variant doesn't work on Select as you can see on my new demo page.
Thanks,
Julien Usson
Closes #13049