[test] Fail if coverage can't be push #13084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added a commit
to eps1lon/material-ui
that referenced
this pull request
Oct 3, 2018
eps1lon
force-pushed
the
ci/explicit-codecov-fail
branch
from
a1594e4 to
46d4bd6
Compare
eps1lon
commented
Oct 3, 2018
.circleci/config.yml
Outdated
| fi | ||
| - run: | ||
| name: Coverage | ||
| command: bash <(curl -s https://codecov.io/bash) -Z |
There was a problem hiding this comment.
-Z is the important change here.
|
What do you think of keeping the existing build steps? Because running the regression tests is an intensive task, we only do it once all the other tests are green. |
|
@oliviertassinari I only looked at the CI runtime but |
|
Can we keep it into test_unit?
We only have 4 containers that can be run in parallel. Adding a fith step will slow the builds. Don't worry, CircleCi has already been optimized. |
|
Sure, better keep it simple |
The coverage report could previously fail silently which could leave codecov in an indeterminate pending state. If the report fails now CI will also fail.
eps1lon
force-pushed
the
ci/explicit-codecov-fail
branch
from
3e6a9af to
fc1e45a
Compare
oliviertassinari
approved these changes
Oct 3, 2018
Ok, found it in https://codecov.io/bash |
|
Well done! |
oliviertassinari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The coverage report could previously fail silently which could leave codecov in an infinite pending state. If the report fails now CI will also fail.
Since this didn't test anything that test:unit didn't test already I moved this to another job so that it doesn't block other jobs because of a simple network error.See codecov/codecov-bash#134