-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Typography] Small improvements #13129
[Typography] Small improvements #13129
Conversation
oliviertassinari
commented
Oct 6, 2018
•
edited
Loading
edited
- Switch the default variant between typography v1 and v2.
- Don't apply the scale twice
- Round the letter spacing value
- Makes Material-UI less opinionated regarding the letter-spacing value. I think that the specification is promoting a too strong letter-spacing value, at least for a minor release. I'm softening the change.
e5a409f
to
ed71e84
Compare
ed71e84
to
ff568f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really lost how it is less opinionated to apply letter-spacing you seem appropriate instead of the letter spacing that is defined in the spec. I also fail to see why this is a concern for versioning. We're adding a new feature that is completely backwards compatible. What do you mean by "softening"?
It's the second time you want to change this. Do we want to implement the spec or do we interpret the spec?
@@ -324,7 +332,6 @@ Typography.defaultProps = { | |||
headlineMapping: defaultHeadlineMapping, | |||
noWrap: false, | |||
paragraph: false, | |||
variant: 'body1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a breaking change. What's the purpose of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this a breaking change?
We do interpret the specification, as Google is doing with all its products. Even the Material Design specification website and the MDC Web implementations are interpreting the typography spec. There are two topics here. |