-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Clarify on how to use the local distribution in the CONTRIBUTING file #13312
[docs] Clarify on how to use the local distribution in the CONTRIBUTING file #13312
Conversation
In this commit, we are clarifying how to install the local distribution of Material-UI to test changes on a real case scenario. It turns out that, if you don't point the instalation to the /build folder, when importing a Material-UI component, the path "@material-ui/core/<ComponentName>" does not work. It took me a while to realize how to install the local distribution, that's why I decided to update the documentation.
Thank you. |
For testing with a local distribution we should probably recommend linking ( At least that's how |
Indeed, just after submitting this PR I realized we could use Using I'm going to try to set up my local environment with |
@nicolasiensen I know you figured it already out with |
I managed to make it work with Nevertheless, I still have to manually rebuild the library when a change is introduced, and the build process is going to process all the components, even if I'm changing just one, taking more than 25s. It would be cool if yarn could watch the changes I'm doing in |
Have you tried adding You could also just use Overall I think you shouldn't be doing that. If you work on a fix for this package and want manual e2e testing use |
* Recommend yarn link to test local distribution In this commit, we are updating the CONTRIBUTING file to recommend using "yarn link" to test the local distribution of Material-UI. This approach was discussed in #13312 * Empty commit to force codecov to work
In this commit, we are clarifying how to install the local distribution of Material-UI to test changes in a real case scenario.
It turns out that, if you don't point the installation to the
/build
folder when importing a Material-UI component, the path@material-ui/core/<ComponentName>
does not work.It took me a while to realize how to install the local distribution, that's why I decided to update the documentation.