-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Fix running docs:api on Windows and other minor spelling mistakes #13989
Conversation
e298818
to
73c1d12
Compare
@joshwooding wow, you have just made @mbrookes the happiest man. Well done! 👌 |
@joshwooding Awesome! @oliviertassinari I thought we were going to wait 24 hours from review to merge? I found a correction to a correction. 😄 |
A correction to a correction 🎅 |
@mbrookes What was the correction? |
- anymore
+ any more But honestly, in the grand scheme of things it's tiny - I can't believe how many typos, spelling mistakes and grammatical errors you managed to find! |
@mbrookes Ahh okay, I guess since anymore is valid in American English I didn't fully pick up on it. I'm still confused about whether the documentation is written in American English or British English due to the amount of 'z's I normally try to write in American English. I'm sure there are more to find :P Sadly there doesn't seem to be many good tools on spell checking over this sort of stuff |
I would lean towards American English because it has a broader audience. |
Learned something new! Yes, we've been using (mostly) American English (e.g. 'color'), but now doubt plenty of British / International English spellings have slipped in. |
I have followed (at least) the PR section of the contributing guide.
Fixed running
docs:api
on Windows 🎉Other minor spelling mistakes
I've already made the capitalization fixes on crowdin
Closes #13972