Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix running docs:api on Windows and other minor spelling mistakes #13989

Merged
merged 3 commits into from
Dec 24, 2018

Conversation

joshwooding
Copy link
Member

@joshwooding joshwooding commented Dec 23, 2018

I've already made the capitalization fixes on crowdin

Closes #13972

@oliviertassinari
Copy link
Member

@joshwooding wow, you have just made @mbrookes the happiest man. Well done! 👌

@mbrookes
Copy link
Member

@joshwooding Awesome!

@oliviertassinari I thought we were going to wait 24 hours from review to merge? I found a correction to a correction. 😄

@oliviertassinari
Copy link
Member

A correction to a correction 🎅

@joshwooding
Copy link
Member Author

@mbrookes What was the correction?

@joshwooding joshwooding deleted the spelling-changes branch December 28, 2018 01:45
@mbrookes
Copy link
Member

@joshwooding

- anymore
+ any more

(https://github.com/mui-org/material-ui/pull/13989/files#diff-39e7b753e605707c8bb4540a78d52a42L125)

But honestly, in the grand scheme of things it's tiny - I can't believe how many typos, spelling mistakes and grammatical errors you managed to find!

@joshwooding
Copy link
Member Author

@mbrookes Ahh okay, I guess since anymore is valid in American English I didn't fully pick up on it. I'm still confused about whether the documentation is written in American English or British English due to the amount of 'z's I normally try to write in American English. I'm sure there are more to find :P Sadly there doesn't seem to be many good tools on spell checking over this sort of stuff

@oliviertassinari
Copy link
Member

I would lean towards American English because it has a broader audience.

@mbrookes
Copy link
Member

anymore is valid in American English

Learned something new!

Yes, we've been using (mostly) American English (e.g. 'color'), but now doubt plenty of British / International English spellings have slipped in.

@zannager zannager added the core Infrastructure work going on behind the scenes label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check typo's in code in all repository
4 participants