Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[styles] Document withStyles defaultTheme option #14029

Merged
merged 2 commits into from
Dec 30, 2018
Merged

[styles] Document withStyles defaultTheme option #14029

merged 2 commits into from
Dec 30, 2018

Conversation

joshwooding
Copy link
Member

Closes #14024

@oliviertassinari
Copy link
Member

It should be supported by the styled, withStyles and makeStyles APIs.

@joshwooding
Copy link
Member Author

Oops, okay. I’ll add it for the rest. Is the description okay?

@oliviertassinari
Copy link
Member

The description sounds great.

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. labels Dec 29, 2018
@joshwooding
Copy link
Member Author

@oliviertassinari I can't see where makeStyles would use it?
https://github.com/mui-org/material-ui/blob/605d3d02d3cb03c03bd2b301651c013181bc3ac2/packages/material-ui-styles/src/makeStyles.js#L31

@oliviertassinari
Copy link
Member

@joshwooding Oh, it doesn't 😱. We gonna have to change this at some point if we want to change the core component usages from withStyles to makeStyles.

@joshwooding joshwooding mentioned this pull request Dec 29, 2018
Merged
1 task
@oliviertassinari oliviertassinari merged commit e454aa0 into mui:master Dec 30, 2018
@joshwooding joshwooding deleted the document-styles-withStyles-default-theme branch December 30, 2018 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshwooding @oliviertassinari