[Popover] Forward refs #14737
Merged
[Popover] Forward refs #14737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: a574657...68bf089
|
eps1lon
commented
Mar 4, 2019
| @@ -659,10 +655,6 @@ describe('<Popover />', () => { | |||
| positioningStyle = instance.getPositioningStyle(element); | |||
| }); | |||
|
|
|||
| after(() => { | |||
| instance.getAnchorOffset = stub().returns(anchorOffset); | |||
There was a problem hiding this comment.
Was c&p from following tests that stubbed instance.getAnchorOffset differently.
eps1lon
commented
Mar 4, 2019
| @@ -331,7 +333,6 @@ class Popover extends React.Component { | |||
| onExit={onExit} | |||
| onExited={onExited} | |||
| onExiting={onExiting} | |||
| role={role} | |||
There was a problem hiding this comment.
Not sure why we would want the role on the TransitionComponent. There was no test for it nor internal usage. Change that added this is missing.
There was a problem hiding this comment.
This logic hasn't changed since the first commit. I'm happy to remove it 👍
5 tasks
eps1lon
force-pushed
the
feat/Popover/forwardRef
branch
from
06d2709 to
68bf089
Compare
oliviertassinari
approved these changes
Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues #14536