Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[theme] Prepare the deprecation of theme.mixins.gutters #15124

Merged
merged 1 commit into from
Apr 1, 2019
Merged

[theme] Prepare the deprecation of theme.mixins.gutters #15124

merged 1 commit into from
Apr 1, 2019

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Mar 30, 2019 •
edited by eps1lon
Loading

Closes #11539. I'm not aware of any valid use case for theme.mixins.gutters. Most of the time, people would be better off with custom CSS or the Box API: https://material-ui.com/system/spacing/.
We have the following plan of action:

  • v4: remove usage from the documentation
  • v4.1: introduce a deprecation.
  • v5: remove the mixin. It will reduce the bundle size a bit. The default theme is a common dependency of all the components, it's important to minimize its size.

@oliviertassinari oliviertassinari changed the title [theme] Deprecate theme.mixins.gutters [theme] Soft deprecate theme.mixins.gutters Mar 30, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Mar 30, 2019 •
edited
Loading

Details of bundle changes.

Comparing: 2c2075e...d570532

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core +0.02% 🔺 +0.01% 🔺 350,279 350,337 89,995 90,008
@material-ui/core/Paper 0.00% 0.00% 67,853 67,853 19,820 19,820
@material-ui/core/Paper.esm 0.00% 0.00% 60,184 60,184 18,562 18,562
@material-ui/core/Popper 0.00% 0.00% 30,463 30,463 10,530 10,530
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 17,364 17,364 5,726 5,726
@material-ui/core/useMediaQuery 0.00% 0.00% 2,469 2,469 1,041 1,041
@material-ui/lab 0.00% 0.00% 148,259 148,259 43,564 43,564
@material-ui/styles 0.00% 0.00% 53,105 53,105 15,434 15,434
@material-ui/system 0.00% 0.00% 17,136 17,136 4,525 4,525
Button 0.00% 0.00% 87,927 87,927 26,052 26,052
Modal 0.00% 0.00% 82,035 82,035 24,551 24,551
colorManipulator 0.00% 0.00% 3,232 3,232 1,299 1,299
docs.landing 0.00% 0.00% 49,899 49,899 10,803 10,803
docs.main +0.02% 🔺 +0.01% 🔺 645,204 645,329 200,433 200,458
packages/material-ui/build/umd/material-ui.production.min.js +0.02% 🔺 0.00% 298,576 298,632 82,774 82,777

Generated by 🚫 dangerJS against d570532

eps1lon
eps1lon approved these changes Mar 31, 2019
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description was misleading. It's only usage.

@oliviertassinari oliviertassinari changed the title [theme] Soft deprecate theme.mixins.gutters [theme] S theme.mixins.gutters Mar 31, 2019
@oliviertassinari oliviertassinari changed the title [theme] S theme.mixins.gutters [theme] Prepare the deprecation oftheme.mixins.gutters Mar 31, 2019
@oliviertassinari oliviertassinari changed the title [theme] Prepare the deprecation oftheme.mixins.gutters [theme] Prepare the deprecation of theme.mixins.gutters Mar 31, 2019
@oliviertassinari oliviertassinari merged commit aa9840c into mui:next Apr 1, 2019
@oliviertassinari oliviertassinari deleted the kill-mixins-gutters branch April 1, 2019 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
deprecation New deprecation message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliviertassinari @mui-pr-bot @eps1lon