Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Textarea] Remove rowsMin prop #15430

Merged
merged 4 commits into from
Apr 22, 2019
Merged

[Textarea] Remove rowsMin prop #15430

merged 4 commits into from
Apr 22, 2019

Conversation

pachuka
Copy link
Contributor

@pachuka pachuka commented Apr 21, 2019 •
edited
Loading

Reverted changes from #15411 and removed rowsMin prop.

Closes #15407

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 21, 2019 •
edited
Loading

Details of bundle changes.

Comparing: 947853d...0e39195

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core -0.02% -0.05% 310,220 310,154 83,872 83,832
@material-ui/core/Paper 0.00% 0.00% 67,276 67,276 19,971 19,971
@material-ui/core/Paper.esm 0.00% 0.00% 60,639 60,639 18,886 18,886
@material-ui/core/Popper 0.00% 0.00% 31,114 31,114 10,799 10,799
@material-ui/core/Textarea -0.11% -0.13% 5,327 5,321 2,288 2,285
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 15,898 15,898 5,771 5,771
@material-ui/core/useMediaQuery 0.00% 0.00% 2,106 2,106 973 973
@material-ui/lab 0.00% 0.00% 140,804 140,804 42,600 42,600
@material-ui/styles 0.00% 0.00% 50,831 50,831 15,018 15,018
@material-ui/system 0.00% 0.00% 11,765 11,765 3,925 3,925
Button 0.00% 0.00% 85,620 85,620 25,616 25,616
Modal 0.00% 0.00% 79,229 79,229 23,936 23,936
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 50,908 50,908 11,210 11,210
docs.main -0.01% -0.00% 646,309 646,275 201,599 201,592
packages/material-ui/build/umd/material-ui.production.min.js -0.02% -0.04% 291,768 291,702 81,995 81,961

Generated by 🚫 dangerJS against 0e39195

@joshwooding joshwooding added the component: text field This is the name of the generic UI component, not the React module! label Apr 21, 2019
@joshwooding joshwooding changed the title [TextField] Removed rowsMin prop [Textarea] Remove rowsMin prop Apr 21, 2019
oliviertassinari
oliviertassinari reviewed Apr 21, 2019
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking it up :)

packages/material-ui/src/InputBase/InputBase.js Show resolved Hide resolved
@oliviertassinari oliviertassinari added this to the v4 milestone Apr 21, 2019
oliviertassinari
oliviertassinari approved these changes Apr 21, 2019
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done :)

@oliviertassinari oliviertassinari added PR: good for merge component: TextareaAutosize The React component. and removed component: text field This is the name of the generic UI component, not the React module! labels Apr 21, 2019
@oliviertassinari oliviertassinari merged commit 69466d8 into mui:next Apr 22, 2019
@pachuka pachuka deleted the refactor/text-field-rows branch April 22, 2019 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshwooding joshwooding joshwooding left review comments

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: TextareaAutosize The React component.
Projects
None yet
Milestone
v4
Development

Successfully merging this pull request may close these issues.

[Textarea] Remove rowsMin, use the rows prop instead
4 participants
@pachuka @mui-pr-bot @oliviertassinari @joshwooding