Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Fail when demos are only available in TS #15460

Merged
merged 2 commits into from
Apr 23, 2019
Merged

[ci] Fail when demos are only available in TS #15460

merged 2 commits into from
Apr 23, 2019

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Apr 23, 2019 •
edited
Loading

git diff does not include untracked files. This means demos that are only available in TS are not flagged properly.

TODO:

@eps1lon eps1lon added docs Improvements or additions to the documentation test typescript labels Apr 23, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Apr 23, 2019 •
edited
Loading

No bundle size changes comparing 387b79e...101d75a

Generated by 🚫 dangerJS against 101d75a

@eps1lon eps1lon force-pushed the ci/fail-new-demos branch from fd458c3 to b928b92 Compare April 23, 2019 15:33
@oliviertassinari
Copy link
Member

A nice rebase issue spotted!

@eps1lon eps1lon merged commit 07e3412 into mui:next Apr 23, 2019
@eps1lon eps1lon deleted the ci/fail-new-demos branch April 23, 2019 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation test typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eps1lon @mui-pr-bot @oliviertassinari