Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 slider focus doesn't affect other components focus #15535

Closed
wants to merge 1 commit into from

Conversation

el1f
Copy link
Contributor

@el1f el1f commented Apr 30, 2019

fixed: #13871

I'm not sure that this change is the best way to solve the issue on-hand but I tried to test it to the best of my ability to make sure it doesn't cause any mishaps.

@mui-pr-bot
Copy link

Details of bundle changes.

Comparing: 7869aac...adde740

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core 0.00% 0.00% 311,022 311,022 84,579 84,579
@material-ui/core/Paper 0.00% 0.00% 67,623 67,623 20,121 20,121
@material-ui/core/Paper.esm 0.00% 0.00% 60,988 60,988 19,018 19,018
@material-ui/core/Popper 0.00% 0.00% 31,114 31,114 10,805 10,805
@material-ui/core/Textarea 0.00% 0.00% 5,468 5,468 2,364 2,364
@material-ui/core/TrapFocus 0.00% 0.00% 3,731 3,731 1,565 1,565
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 15,943 15,943 5,777 5,777
@material-ui/core/useMediaQuery 0.00% 0.00% 2,106 2,106 974 974
@material-ui/lab -0.01% 0.00% 140,444 140,425 42,608 42,608
@material-ui/styles 0.00% 0.00% 51,151 51,151 15,149 15,149
@material-ui/system 0.00% 0.00% 11,765 11,765 3,923 3,923
Button 0.00% 0.00% 85,266 85,266 25,677 25,677
Modal 0.00% 0.00% 20,575 20,575 6,601 6,601
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 51,531 51,531 11,368 11,368
docs.main 0.00% 0.00% 649,455 649,455 202,645 202,645
packages/material-ui/build/umd/material-ui.production.min.js 0.00% 0.00% 292,809 292,809 82,545 82,545

Generated by 🚫 dangerJS against adde740

@eps1lon
Copy link
Member

eps1lon commented Apr 30, 2019

@el1f Sorry but someone is already working on this in #15439. I didn't realize there were two duplicate issue.

@eps1lon eps1lon closed this Apr 30, 2019
@zannager zannager added the component: slider This is the name of the generic UI component, not the React module! label Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: slider This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Slider] Slider doesnt get focus when sliding
4 participants