Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix Nav components subsections to be open by default #15749

Merged
merged 3 commits into from
May 21, 2019

Conversation

mbrookes
Copy link
Member

@mui-pr-bot
Copy link

mui-pr-bot commented May 19, 2019

Details of bundle changes.

Comparing: 6b73158...9e4f2d4

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core 0.00% 0.00% 315,279 315,279 86,429 86,429
@material-ui/core/Paper 0.00% 0.00% 67,869 67,869 20,159 20,159
@material-ui/core/Paper.esm 0.00% 0.00% 61,152 61,152 18,952 18,952
@material-ui/core/Popper 0.00% 0.00% 28,740 28,740 10,351 10,351
@material-ui/core/Textarea 0.00% 0.00% 5,513 5,513 2,382 2,382
@material-ui/core/TrapFocus 0.00% 0.00% 3,744 3,744 1,581 1,581
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 15,960 15,960 5,782 5,782
@material-ui/core/useMediaQuery 0.00% 0.00% 2,106 2,106 975 975
@material-ui/lab 0.00% 0.00% 138,336 138,336 42,572 42,572
@material-ui/styles 0.00% 0.00% 51,353 51,353 15,175 15,175
@material-ui/system 0.00% 0.00% 14,458 14,458 4,178 4,178
Button 0.00% 0.00% 84,061 84,061 25,579 25,579
Modal 0.00% 0.00% 20,344 20,344 6,685 6,685
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 47,836 47,836 10,920 10,920
docs.main 0.00% 0.00% 654,121 654,143 205,688 205,697
packages/material-ui/build/umd/material-ui.production.min.js 0.00% 0.00% 294,254 294,254 83,882 83,882

Generated by 🚫 dangerJS against 9e4f2d4

@oliviertassinari
Copy link
Member

oliviertassinari commented May 19, 2019

That's not an easy one 😆⚖️ :

expect(document.querySelectorAll('.algolia-lvl0').length).toBe(1) // 🔥 KO

@mbrookes mbrookes added the docs Improvements or additions to the documentation label May 19, 2019
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify my previous message. It breaks the Algolia fix.

@mbrookes
Copy link
Member Author

Oops, didn't realise the algolia logic was also broken. Hope I've correctly understood the desired output.

@mbrookes mbrookes force-pushed the doc-fix-components-open branch from 93bcb43 to 319ab64 Compare May 19, 2019 22:52
@mbrookes mbrookes requested a review from oliviertassinari May 20, 2019 12:10
@oliviertassinari
Copy link
Member

I believe the following solve your problem and mine. Let me know.

@oliviertassinari oliviertassinari merged commit 0e2f28b into mui:next May 21, 2019
@mbrookes mbrookes deleted the doc-fix-components-open branch May 22, 2019 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants