[Tooltip] Fix alignment issues #15811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #15194 and #15731. These bugs seem to be caused by the tooltip popper adding unintended spacing to the DOM just before calculating the transform, making the calculations incorrect when the actual tooltip popper style attribute is filled. By forcing the tooltip popper to never cause spacing when it enters the DOM, the calculation is now correct.
Details of bundle changes.Comparing: 89687f3...f71e679
|
This reverts commit 8b67ef7.
oliviertassinari
added
bug 🐛
oliviertassinari
approved these changes
May 24, 2019
|
@pkmnct It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15194 and fixes #15731.
These bugs seem to be caused by the tooltip popper adding unintended spacing to the DOM just before calculating the transform, making the calculations incorrect when the actual tooltip popper style attribute is filled. By forcing the tooltip popper to never cause spacing when it enters the DOM, the calculation is now correct.